Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added configuration option to disable queue instrumentation #44

Merged
merged 3 commits into from
Jan 9, 2020
Merged

Added configuration option to disable queue instrumentation #44

merged 3 commits into from
Jan 9, 2020

Conversation

asgrim
Copy link
Collaborator

@asgrim asgrim commented Jan 7, 2020 •
edited
Loading

Part of #43

Todo

@asgrim asgrim added the enhancement New feature or request label Jan 7, 2020
@asgrim asgrim added this to the 1.2.2 milestone Jan 7, 2020
@asgrim asgrim requested a review from cschneid January 7, 2020 09:44
@asgrim asgrim mentioned this pull request Jan 7, 2020
Closed
asgrim
asgrim commented Jan 7, 2020
View reviewed changes
@asgrim asgrim added the WIP Work in progress - do not merge label Jan 7, 2020
@asgrim asgrim assigned asgrim and unassigned cschneid Jan 7, 2020
@asgrim asgrim removed the request for review from cschneid January 7, 2020 09:56
@cschneid
Copy link

cschneid commented Jan 7, 2020

For parity w/ ruby and flexibility later to turn on & off instruments, can we have a more general config: disabled_instruments

https://docs.scoutapm.com/#disabled_instruments

In Ruby, it's the name of classes, but it can be text names instead. laravel_queues and so on.

@asgrim asgrim mentioned this pull request Jan 8, 2020
Merged
@asgrim asgrim removed the WIP Work in progress - do not merge label Jan 9, 2020
@asgrim asgrim merged commit 8fe93c4 into master Jan 9, 2020
@asgrim asgrim deleted the add-config-to-disable-queue-instrumentation branch January 9, 2020 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@asgrim asgrim

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@asgrim @cschneid