Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Update header value format to be "Chrome parsable" #6

Closed

Conversation

PikachuEXE
Copy link

Fixes #5

I understand that the format updated format is not what's specified in W3C draft

But it works:

Middleware=11241.11 ,ActiveRecord=54.18 ,Router=472.69 ,Controller=51.4 ,Redis=49.86 ,View=16536.12 ,Total=28405.39

screen shot 2018-03-05 at 4 33 33 pm

Until the spec is finalized, I think we should use a format that Chrome can parse now

@itsderek23
Copy link
Contributor

Thanks much @PikachuEXE. Based on the additional information provided in the comment thread on #5, I've instead added a note to the README on Chrome 64 support. See 9a10c2e.

@itsderek23 itsderek23 closed this Mar 5, 2018
@PikachuEXE PikachuEXE deleted the make-value-chrome-parsable branch March 6, 2018 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants