fix: add missing parameters to abstract replace method signature #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0d305b8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@TrevorBurnham can you run |
TrevorBurnham
force-pushed
the
fix-scroll-option
branch
from
15189e1 to
6c013d2
Compare
TrevorBurnham
force-pushed
the
fix-scroll-option
branch
from
6c013d2 to
0d305b8
Compare
|
@scottrippey Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #127
AFAICT the bug report must be referencing a TypeScript error, not a functional error. This PR fixes that type error and adds unit tests for passing options such asUpdate: Although the bug report prompted this PR, the issue this PR fixes is different. The bug report involves the App Router, whereas this PR adds missing types for the Pages Router.scrollto bothreplaceandpush.