Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated ghooks with husky #5

Conversation

giodamelio
Copy link
Contributor

When I was working on #4 I noticed that ghooks has been deprecated in favor of husky. So I threw together a quick pull to migrate to it. It's pretty straightforward except you have to delete all your git hooks(rm .git/hooks/*) before you install husky to allow it to make it's own.

@scottnonnenberg
Copy link
Owner

I hadn't heard about that - thanks for the heads-up and change! One request - can you change the version from ^0.12.0 to just plain 0.12.0?

@giodamelio giodamelio force-pushed the chore-replace-ghooks-with-husky branch from 599dc1c to 0f19d41 Compare January 19, 2017 22:45
@giodamelio
Copy link
Contributor Author

Done

@giodamelio giodamelio force-pushed the chore-replace-ghooks-with-husky branch from 0f19d41 to 0237a31 Compare January 19, 2017 22:51
@giodamelio
Copy link
Contributor Author

Done for real this time. Gotta remember those git add's...

@scottnonnenberg scottnonnenberg merged commit 9083647 into scottnonnenberg:master Jan 20, 2017
@giodamelio giodamelio deleted the chore-replace-ghooks-with-husky branch January 20, 2017 01:12
@scottnonnenberg
Copy link
Owner

Thanks. Got this working only after updating standard-version, which was blowing up on npm's meta-output on stderr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants