SNI implementation for tray icons #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scorpion-26
changed the title
scorpion-26
force-pushed
the
sni
branch
4 times, most recently
from
2cf717e
to
7f22f01
Compare
|
All major features regarding the dbus protocol are now implemented. |
scorpion-26
force-pushed
the
sni
branch
5 times, most recently
from
fee5919
to
39b45ec
Compare
Implements a rough outline of the SNI (StatusNotifierItem) d-bus protocol for tray icons. Note: This is currently *very* WIP Full implementation will close #5
Qt waits until the callback to RegisterItem is done. Thus, we can't query the item and need to defer it
Since it uses a 13 year old library, it is broken. The popup size is hard-fixed at 200x200, with looks really ugly with non-transparent background.
scorpion-26
changed the title
scorpion-26
added a commit
that referenced
this pull request
Mar 18, 2024
This is the fix for #79, but blown out of proportions, because various things kept breaking - Original fix: Add/Remove items instead of cleaning everything everytime something changes. If the dbus-menu was open, it was referencing the old widget causing issues. The new method keeps the original GtkDrawingArea and only replace the buffer/tooltip - Create dbus-menu on widget creation instead of on click. This was actually the fix for #12 (comment). The css has also been updated, making the popup finally look good. - With the new item refreshing theme KeePassXC kept deadlocking when the properties changed. To fix it, the dbus properties are now queried asynchronously via 'GetAll'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for SNI (StatusNotifierItem) d-bus protocol for tray icons.
Note: This is currently very WIP
Things that need to be done until it is ready for merging into master:
Full implementation will close #5