Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for Issue and Comment Endpoints #660

Merged
merged 1 commit into from
Jul 17, 2022

Conversation

vaishnavi-gupta18
Copy link
Collaborator

Description

Add unit tests for Issue and comment API endpoints.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@amlannandy amlannandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. LGTM.
One more thing we can do is add descriptions for each test. Maybe using doc strings?
Let's just merge this for now. We can pick that up later with other documentation stuff.

@amlannandy amlannandy merged commit 204d60c into scorelab:master Jul 17, 2022
@vaishnavi-gupta18 vaishnavi-gupta18 added GSoC 2022 Tasks related to GSoC 2022 backend Issue and PR regarding backend labels Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Issue and PR regarding backend GSoC 2022 Tasks related to GSoC 2022
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants