Removes erlang:get_stacktrace() function calls #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pushkar-thescore
requested review from
a team,
robertkeizer,
Ammar-T and
darrenclark
and removed request for
a team
|
I don't see any issues with this. Upstream has the change, I don't see any functional issues given we're not going to be parsing the stacktrace on a catch. Confirmed in the repos that are using this ( |
darrenclark
approved these changes
Sep 30, 2021
There was a problem hiding this comment.
Thanks for submitting the change @pushkar-thescore , and thanks for checking this @robertkeizer!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
erlang:get_stacktracefunction is no longer supported in OTP 24. This PR replaces this function call.Original issue: elixir-grpc#203
Original fix: elixir-grpc#205