Change region_name to None if empty string #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Botocore checks for None as opposed to empty string and will not generate endpoints properly for global services when an empty string is passed.
|
This looks good. Just wondering if we want to pin the boto3 version in this same PR or not. |
|
I would be fine with adding pinning to a specific version if you would look into getting requires.io or equivalent setup. It is a very straight forward setup and handles auto opening prs as your upstreams change versions. This way as upstreams changes you can automates tests around them (which would have caught the issue in this case) and allow you to be more proactive and ensure you are using recent versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Botocore checks for None as opposed to empty string when trying to generate a default endpoint . In skew's current form with the way versions are pinned it will not generate endpoints properly for global services when an empty string is passed in recent versions of boto3/botocore.
Current tests fail but since no recent merges have been made its not apparent. This small change should get tests passing and global service endpoints generating properly again.
Resolves #96