Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Hugging face async coverage #44

Merged
merged 2 commits into from
Jan 2, 2025
Merged

fix: Hugging face async coverage #44

merged 2 commits into from
Jan 2, 2025

Conversation

kevdevg
Copy link
Contributor

@kevdevg kevdevg commented Jan 2, 2025 •
edited
Loading

Fixing some problems in async text generation for Hugging face

@coveralls
Copy link
Collaborator

coveralls commented Jan 2, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12587712793

Details

  • 18 of 18 (100.0%) changed or added relevant lines in 1 file are covered.
  • 15 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+13.2%) to 93.803%
Files with Coverage Reduction New Missed Lines %
scope3ai/tracers/openai/chat.py 1 86.75%
scope3ai/worker.py 5 89.69%
scope3ai/lib.py 9 89.57%
Totals Coverage Status
Change from base Build 12553763769: 13.2%
Covered Lines: 1332
Relevant Lines: 1420
💛 - Coveralls

@kevdevg kevdevg merged commit 4b41096 into main Jan 2, 2025
19 checks passed
@kevdevg kevdevg deleted the kevdevg/hugging-face-async-coverage branch January 9, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tito tito tito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevdevg @coveralls @tito