Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing close of hg diff command #1417

Merged
merged 1 commit into from
Nov 16, 2020
Merged

Conversation

sdorra
Copy link
Member

@sdorra sdorra commented Nov 10, 2020

Proposed changes

The mercurial diff resource does not close the command context, which leads to an open python process which gets never closed.

Your checklist for this pull request

  • PR is well described
  • Related issues linked to PR if existing and labels set
  • Target branch is not master (in most cases develop should bet the target of choice)
  • Code does not conflict with target branch
  • New code is covered with unit tests
  • CHANGELOG.md updated
  • Definition of Done's fulfilled: DoD // UI DoD
  • Documentation updated (only necessary for new features or changed behaviour)

Checklist for branch merge request (not required for forks)

@sdorra sdorra added the bug Something isn't working label Nov 10, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

90.0% 90.0% Coverage
0.0% 0.0% Duplication

@eheimbuch eheimbuch self-assigned this Nov 16, 2020
@eheimbuch eheimbuch merged commit a0e7073 into develop Nov 16, 2020
@eheimbuch eheimbuch deleted the bugfix/close_hg_diff_stream branch November 16, 2020 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants