-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/user converter #1380
Merged
Merged
Feature/user converter #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pilopa
suggested changes
Oct 20, 2020
scm-webapp/src/main/java/sonia/scm/api/v2/resources/UserToUserDtoMapper.java
Outdated
Show resolved
Hide resolved
scm-webapp/src/main/java/sonia/scm/user/DefaultUserManager.java
Outdated
Show resolved
Hide resolved
scm-webapp/src/test/java/sonia/scm/api/v2/resources/UserToUserDtoMapperTest.java
Show resolved
Hide resolved
Pilopa
reviewed
Oct 21, 2020
b7f29d5
to
69950f6
Compare
…o user form in ui
…anager into feature/user_converter
sdorra
requested changes
Oct 27, 2020
scm-core/src/main/java/sonia/scm/security/SyncingRealmHelper.java
Outdated
Show resolved
Hide resolved
scm-core/src/main/java/sonia/scm/user/ExternalUserConverter.java
Outdated
Show resolved
Hide resolved
sdorra
requested changes
Oct 28, 2020
…anager into feature/user_converter
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Create automatic user converter which converts internal users to external if they log in through an external system like ldap. This automatic converted can be enabled in the global config. Also users can now be converted manually between internal and external.
Your checklist for this pull request
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Checklist for branch merge request (not required for forks)