Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/user converter #1380

Merged
merged 34 commits into from
Oct 30, 2020
Merged

Feature/user converter #1380

merged 34 commits into from
Oct 30, 2020

Conversation

eheimbuch
Copy link

@eheimbuch eheimbuch commented Oct 19, 2020

Proposed changes

Create automatic user converter which converts internal users to external if they log in through an external system like ldap. This automatic converted can be enabled in the global config. Also users can now be converted manually between internal and external.

Your checklist for this pull request

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • PR is well described
  • Related issues linked to PR if existing and labels set
  • Target branch is not master (in most cases develop should bet the target of choice)
  • Code does not conflict with target branch
  • New code is covered with unit tests
  • CHANGELOG.md updated
  • Definition of Done's fulfilled: DoD // UI DoD
  • Documentation updated (only necessary for new features or changed behaviour)

Checklist for branch merge request (not required for forks)

@eheimbuch eheimbuch added the enhancement New feature or request label Oct 19, 2020
docs/en/user/admin/settings.md Outdated Show resolved Hide resolved
docs/en/user/user/index.md Outdated Show resolved Hide resolved
docs/en/user/user/settings.md Outdated Show resolved Hide resolved
docs/en/user/user/settings.md Outdated Show resolved Hide resolved
docs/en/user/user/settings.md Outdated Show resolved Hide resolved
@eheimbuch eheimbuch force-pushed the feature/user_converter branch from b7f29d5 to 69950f6 Compare October 21, 2020 10:48
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 14 Code Smells

26.0% 26.0% Coverage
6.8% 6.8% Duplication

@eheimbuch eheimbuch merged commit b48bf24 into develop Oct 30, 2020
@eheimbuch eheimbuch deleted the feature/user_converter branch October 30, 2020 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants