Simplified secondary navigation #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ExtensionPoint component supports now the transformation of instance props and allows binding of already instantiated react components (Foo vs <Foo />).
This makes it possible to define other routes that "/" inside each story.
eheimbuch
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR simplifies the collapse state management of the secondary navigation. The Menu is now collapsible regardless if the entry has sub navigation items or not. The menu gets automatically uncollapsed on every interaction with the menu.
The ExtensionPoint component is now able to handle react component instances and not only react components (Foo vs ). Also a propTransformer was introduced to transform the react props which are delegated to the extensions.
This should make the menu behave more consistent and simplifies the implementation drastically.
Your checklist for this pull request
Checklist for branch merge request (not required for forks)