Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use multiple sources for verifying gosu package #783

Merged
merged 1 commit into from
May 17, 2017

Conversation

ryansanford
Copy link
Contributor

@ryansanford ryansanford commented May 16, 2017

Resolves #782

Borrowed the workaround from tianon/gosu#35 (comment)

Review Checklist

  • Tests were added to cover all code changes
  • Documentation was added / updated
  • Code and tests follow standards in CONTRIBUTING.md

@ryansanford ryansanford requested a review from gsfr May 16, 2017 18:49
@ryansanford
Copy link
Contributor Author

@gsfr Mind giving this a once-over before I merge?

Copy link
Member

@gsfr gsfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Can we get an upgrade to buildpack-deps:xenial and a reduction of installed packages in at the same time?

@ryansanford
Copy link
Contributor Author

@gsfr
Thanks for the review.

I think using buildpack-deps and a reduction of installed packages are conflicting goals. We should modernize the base image, and confirm only the required packages are used. I'll open separate issue for that.

@ryansanford ryansanford merged commit 0d0c49c into master May 17, 2017
@ryansanford ryansanford deleted the robust-docker-build branch May 17, 2017 15:09
@ryansanford
Copy link
Contributor Author

Opened #786 related to Docker Image maintenance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants