Bootstrap 5 #1379
Merged
Bootstrap 5 #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SIRI-898
The library is no longer maintained and can allegedly be replaced by a bootstrap 5 method.
SIRI-924
This makes dropdowns work again. SIRI-924
Bootstrap 5 generally moves towards better support for Right-to-Left languages. Consequently, `left` and `right` are now replaced by `start` and `end` in the usual Left-to-Right setting. In order not to have too much confusion between frontend and backend, this commit introduces additional, similar class names in the design system. SIRI-924
In general, Bootstrap 5 replaced `left` with `start` and `right` with `end`, in order to support Right-to-Left languages. Also includes further adaptions. See https://getbootstrap.com/docs/5.0/migration/. SIRI-924
SIRI-924
The original strings were of considerably different length, potentially causing the tooltip to jump. SIRI-924
SIRI-924
SIRI-924
This has been forgotten to commit in 7e4f135. SIRI-924
ymo-sci
reviewed
Feb 9, 2024
Previously, only #rrggbb strings have been previewed in the color picker. With this PR, shorthand, color names or other valid CSS color statements are also supported. Note, however, that the original text is sent to the server, not the computed #rrggbb value. SIRI-924
The text is taken from https://github.com/twbs/bootstrap/blob/4e35f64fdc96e505fa659a41ee2e1c1cc87df0d8/LICENSE. This is the most recent version available. SIRI-924
While not part of the original license text, the heading is required to understand to which software the text refers. See the `/licenses` route. SIRI-924
SIRI-924
Sometimes, neither `sirius` not the method seem to be available. We, therefore, just check for the method directly. SIRI-924
sabieber
approved these changes
Feb 10, 2024
fhaScireum
approved these changes
Feb 13, 2024
ymo-sci
approved these changes
Feb 13, 2024
idlira
approved these changes
Feb 13, 2024
SIRI-924
When using the `color` property, a style sheet may interfere. A default background for spans is more unlikely. SIRI-924
Checking the previous implementation, we used to always send the hex value. This commit thus restores the previous behaviour. At the same time, though, input of non-RGB colors is no longer possible. SIRI-924
This makes it more clear to the user which color will actually be sent. SIRI-924
SIRI-924
SIRI-924
sabieber
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ports Tycho to Bootstrap 5.
Additional Notes
Checklist