Skip to content

ram_pcd_message: pass libff::bit_vector by const reference to avoid copies #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ram_pcd_message: pass libff::bit_vector by const reference to avoid copies #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e20d94
Update ram_compliance_predicate.tcc
MozirDmitriy Sep 4, 2025
4b4b851
Update ram_compliance_predicate.hpp
MozirDmitriy Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions libsnark/zk_proof_systems/zksnark/ram_zksnark/ram_compliance_predicate.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,12 @@ class ram_pcd_message : public r1cs_pcd_message<ram_base_field<ramT> > {
ram_pcd_message(const size_t type,
const ram_architecture_params<ramT> &ap,
const size_t timestamp,
const libff::bit_vector root_initial,
const libff::bit_vector root,
const libff::bit_vector &root_initial,
const libff::bit_vector &root,
const size_t pc_addr,
const libff::bit_vector cpu_state,
const libff::bit_vector &cpu_state,
const size_t pc_addr_initial,
const libff::bit_vector cpu_state_initial,
const libff::bit_vector &cpu_state_initial,
const bool has_accepted);

libff::bit_vector unpacked_payload_as_bits() const;
Expand Down
8 changes: 4 additions & 4 deletions libsnark/zk_proof_systems/zksnark/ram_zksnark/ram_compliance_predicate.tcc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,12 @@ template<typename ramT>
ram_pcd_message<ramT>::ram_pcd_message(const size_t type,
const ram_architecture_params<ramT> &ap,
const size_t timestamp,
const libff::bit_vector root_initial,
const libff::bit_vector root,
const libff::bit_vector &root_initial,
const libff::bit_vector &root,
const size_t pc_addr,
const libff::bit_vector cpu_state,
const libff::bit_vector &cpu_state,
const size_t pc_addr_initial,
const libff::bit_vector cpu_state_initial,
const libff::bit_vector &cpu_state_initial,
const bool has_accepted) :
r1cs_pcd_message<FieldT>(type),
ap(ap),
Expand Down