-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hold scipptr in variable to eliminate use-after-free errors #160
Conversation
@Andful would be great if you could take another look here, thanks again for your help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I personally would be stricter with unsafety. I would mark a function unsafe if there exists arguments that would cause UB, even if they are edge cases, e.g. NULL or dangling pointers.
See #159 (comment) |
@Andful thanks a lot for the quick and helpful review! you caught a lot of potential issues. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #160 +/- ##
==========================================
- Coverage 76.23% 76.12% -0.12%
==========================================
Files 13 13
Lines 1805 1859 +54
==========================================
+ Hits 1376 1415 +39
- Misses 429 444 +15 ☔ View full report in Codecov by Sentry. |
This is the last part of #152