Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indicator #137

Merged
merged 3 commits into from
Oct 25, 2019
Merged

Fix indicator #137

merged 3 commits into from
Oct 25, 2019

Conversation

matbesancon
Copy link
Member

Adding the constant term to indicator constraints

@codecov
Copy link

codecov bot commented Oct 25, 2019

Codecov Report

Merging #137 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
+ Coverage   18.86%   18.88%   +0.01%     
==========================================
  Files         139      139              
  Lines        4421     4422       +1     
==========================================
+ Hits          834      835       +1     
  Misses       3587     3587
Impacted Files Coverage Δ
src/MOI_wrapper/indicator_constraints.jl 97.22% <100%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ad2329...f28d691. Read the comment docs.

@rschwarz
Copy link
Collaborator

Do you want to merge it, so you get the fix, or wait for new MOI tag? Either way is fine with me.

@matbesancon
Copy link
Member Author

we can merge it now since it is self-contained (and a bug fix kind of needed), once the new MOI is released we can remove the test function

@rschwarz
Copy link
Collaborator

OK, go ahead, then.

@matbesancon matbesancon merged commit 70d8aed into master Oct 25, 2019
@matbesancon matbesancon deleted the fix-indicator branch October 25, 2019 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants