Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for [get|set]HeurTiming #940

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Conversation

pfetsch
Copy link
Contributor

@pfetsch pfetsch commented Dec 16, 2024

We needed to control the timing of heuristics. Since this cannot be changed via parameters, I added an API support her.

Copy link
Collaborator

@Joao-Dionisio Joao-Dionisio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @pfetsch!

Can you please describe a bit what timing is in the docstring? There's this on SCIP:

timingmask, /**< positions in the node solving loop where heuristic should be executed */

Also, if you wouldn't mind, can you add a test (or expand an existing one) in test_heur.py?

@pfetsch
Copy link
Contributor Author

pfetsch commented Dec 16, 2024

I added a test and tried to extend the documentation. Better?

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 52.65%. Comparing base (1db095e) to head (8ad051c).
Report is 42 commits behind head on master.

Files with missing lines Patch % Lines
src/pyscipopt/scip.pxi 66.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #940      +/-   ##
==========================================
+ Coverage   52.54%   52.65%   +0.10%     
==========================================
  Files          20       21       +1     
  Lines        4345     4448     +103     
==========================================
+ Hits         2283     2342      +59     
- Misses       2062     2106      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Joao-Dionisio Joao-Dionisio enabled auto-merge (squash) December 16, 2024 10:01
@Joao-Dionisio Joao-Dionisio merged commit 34e03a8 into master Dec 16, 2024
16 checks passed
@Joao-Dionisio
Copy link
Collaborator

Yeah, @pfetsch thank you for the contribution!

@pfetsch
Copy link
Contributor Author

pfetsch commented Dec 16, 2024

@Joao-Dionisio Thanks for the fast review.

@Joao-Dionisio Joao-Dionisio deleted the addHeurTimingControl branch January 16, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants