-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for [get|set]HeurTiming #940
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @pfetsch!
Can you please describe a bit what timing is in the docstring? There's this on SCIP:
timingmask, /**< positions in the node solving loop where heuristic should be executed */
Also, if you wouldn't mind, can you add a test (or expand an existing one) in test_heur.py
?
I added a test and tried to extend the documentation. Better? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #940 +/- ##
==========================================
+ Coverage 52.54% 52.65% +0.10%
==========================================
Files 20 21 +1
Lines 4345 4448 +103
==========================================
+ Hits 2283 2342 +59
- Misses 2062 2106 +44 ☔ View full report in Codecov by Sentry. |
Yeah, @pfetsch thank you for the contribution! |
@Joao-Dionisio Thanks for the fast review. |
We needed to control the timing of heuristics. Since this cannot be changed via parameters, I added an API support her.