-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getnorigconss #845
Add getnorigconss #845
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @Opt-Mucca!
Looking at getVars, it has an argument transformed
, that returns original or transformed variables depending on the argument. I think the syntax should be uniform, but I don't have a strong preference for either one. What do you think, Mark?
(Interestingly, we don't have a way of getting the number of original variables (SCIPgetNOrigVars exists). I can make a PR, but I want to make sure where we're going with this.)
@Joao-Dionisio That is a great suggestion and a complete oversight by me! I will change the behaviour to match (can also add getnorigvars) |
Added changes and actually made the test work now (is just a simple LP that tests that after presolve there are less constraints than we originally added). The only potential issue I see: depending on the function you're using |
I agree that it's annoying, @Opt-Mucca, but I like your solution, you aren't introducing any problems that weren't there before. |
Thanks for adding the extra docstrings |
No description provided.