Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCMP echo problems, see #96 #97

Merged
merged 1 commit into from
Jun 21, 2024
Merged

SCMP echo problems, see #96 #97

merged 1 commit into from
Jun 21, 2024

Conversation

tzaeschke
Copy link
Collaborator

SCMP echo problems, see #96.
This PR does not resolve the issue but clears up some other problems

@tzaeschke tzaeschke self-assigned this Jun 21, 2024
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 21.05263% with 15 lines in your changes missing coverage. Please review.

Files Coverage Δ Complexity Δ
src/main/java/org/scion/jpan/PathMetadata.java 47.14% <ø> (ø) 12.00 <0.00> (ø)
src/main/java/org/scion/jpan/ScmpChannel.java 85.14% <100.00%> (+0.93%) 18.00 <0.00> (ø)
src/main/java/org/scion/jpan/ScionService.java 66.40% <0.00%> (-1.36%) 49.00 <0.00> (ø)
src/main/java/org/scion/jpan/ScionUtil.java 90.10% <0.00%> (-5.24%) 29.00 <0.00> (ø)
...ava/org/scion/jpan/internal/ScionBootstrapper.java 75.65% <0.00%> (-2.58%) 29.00 <0.00> (ø)

@tzaeschke tzaeschke merged commit 3c894a5 into master Jun 21, 2024
8 of 9 checks passed
@tzaeschke tzaeschke deleted the fix/96-scmp-echo-fails branch June 21, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant