Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send() must return 'int' #92

Merged
merged 4 commits into from
Jun 18, 2024
Merged

send() must return 'int' #92

merged 4 commits into from
Jun 18, 2024

Conversation

tzaeschke
Copy link
Collaborator

DatagramChannel.send() should return an int instead of a Path.

@tzaeschke tzaeschke self-assigned this Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 35.07463% with 87 lines in your changes missing coverage. Please review.

Files Coverage Δ Complexity Δ
...n/java/org/scion/jpan/AbstractDatagramChannel.java 84.25% <100.00%> (+0.17%) 74.00 <2.00> (-2.00) ⬆️
...main/java/org/scion/jpan/ScionDatagramChannel.java 82.72% <72.13%> (-13.94%) 24.00 <10.00> (+10.00) ⬇️
src/main/java/org/scion/jpan/PathMetadata.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)

@tzaeschke tzaeschke merged commit c4fea94 into master Jun 18, 2024
8 of 9 checks passed
@tzaeschke tzaeschke deleted the fix/92-send-returns-int branch June 18, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant