Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API refactoring #67

Merged
merged 4 commits into from
May 10, 2024
Merged

API refactoring #67

merged 4 commits into from
May 10, 2024

Conversation

tzaeschke
Copy link
Collaborator

Some API changes:

  • Rename DatagramChannel to ScionDatagramChannel
  • Rename DatagramSocket to ScionDatagramSopcketl and move it to main package
  • Rename ScionSocketOptions starting with SN_ to SCION_

@tzaeschke tzaeschke self-assigned this May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 62.23565% with 125 lines in your changes are missing coverage. Please review.

Files Coverage Δ Complexity Δ
src/main/java/org/scion/jpan/DatagramChannel.java 0.00% <ø> (-96.43%) 0.00 <0.00> (-13.00)
...c/main/java/org/scion/jpan/ScionSocketOptions.java 72.72% <100.00%> (ø) 1.00 <1.00> (ø)
src/main/java/org/scion/jpan/ScmpChannel.java 85.84% <ø> (ø) 16.00 <0.00> (ø)
.../scion/jpan/internal/SelectingDatagramChannel.java 82.50% <ø> (ø) 8.00 <0.00> (?)
src/main/java/org/scion/jpan/ScionService.java 70.99% <50.00%> (ø) 49.00 <1.00> (ø)
...n/java/org/scion/jpan/AbstractDatagramChannel.java 86.93% <66.66%> (ø) 77.00 <0.00> (ø)
...main/java/org/scion/jpan/ScionDatagramChannel.java 96.42% <96.42%> (ø) 13.00 <13.00> (?)
...ain/java/org/scion/jpan/socket/DatagramSocket.java 0.00% <0.00%> (-54.79%) 0.00 <0.00> (-57.00)
.../main/java/org/scion/jpan/ScionDatagramSocket.java 54.78% <54.78%> (ø) 57.00 <57.00> (?)

@tzaeschke tzaeschke merged commit fd7c3cc into master May 10, 2024
8 of 9 checks passed
@tzaeschke tzaeschke deleted the fix/67-API-refactoring branch May 10, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant