Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hosts file parser cleanup #42

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Hosts file parser cleanup #42

merged 2 commits into from
Apr 16, 2024

Conversation

tzaeschke
Copy link
Collaborator

@tzaeschke tzaeschke commented Apr 16, 2024

This change is Reviewable

@tzaeschke tzaeschke self-assigned this Apr 16, 2024
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 71.11111% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 77.40%. Comparing base (382ffe9) to head (2de69f7).

Files Patch % Lines
src/main/java/org/scion/internal/DNSHelper.java 75.00% 5 Missing and 2 partials ⚠️
src/main/java/org/scion/ScionAddress.java 50.00% 2 Missing ⚠️
src/main/java/org/scion/ScionService.java 33.33% 1 Missing and 1 partial ⚠️
.../main/java/org/scion/internal/HostsFileParser.java 80.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #42      +/-   ##
============================================
- Coverage     77.51%   77.40%   -0.11%     
- Complexity      403      404       +1     
============================================
  Files            26       26              
  Lines          1948     1943       -5     
  Branches        260      259       -1     
============================================
- Hits           1510     1504       -6     
  Misses          327      327              
- Partials        111      112       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzaeschke tzaeschke merged commit b046c63 into master Apr 16, 2024
8 of 10 checks passed
@tzaeschke tzaeschke deleted the fix/42-search-domain-cleanup branch April 16, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant