Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DatagramSocket #31

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Add DatagramSocket #31

merged 3 commits into from
Apr 29, 2024

Conversation

tzaeschke
Copy link
Collaborator

@tzaeschke tzaeschke commented Mar 12, 2024

Implement a DatagramSocket with SCION support.


This change is Reviewable

@tzaeschke tzaeschke self-assigned this Mar 12, 2024
@tzaeschke tzaeschke force-pushed the fix/30-datagram-socket branch 3 times, most recently from d6c77ea to 9b4dbb2 Compare March 13, 2024 16:39
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 63.76022% with 133 lines in your changes are missing coverage. Please review.

Project coverage is 75.55%. Comparing base (48a03ab) to head (a6192d8).

Files Patch % Lines
...ain/java/org/scion/jpan/socket/DatagramSocket.java 55.21% 111 Missing and 5 partials ⚠️
...rg/scion/jpan/socket/SelectingDatagramChannel.java 82.05% 3 Missing and 4 partials ⚠️
src/main/java/org/scion/jpan/ScionService.java 71.42% 2 Missing and 2 partials ⚠️
.../java/org/scion/jpan/internal/AddressResolver.java 72.72% 1 Missing and 2 partials ⚠️
...main/java/org/scion/jpan/internal/SimpleCache.java 93.18% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #31      +/-   ##
============================================
- Coverage     77.41%   75.55%   -1.86%     
- Complexity      430      511      +81     
============================================
  Files            28       32       +4     
  Lines          2063     2426     +363     
  Branches        274      298      +24     
============================================
+ Hits           1597     1833     +236     
- Misses          349      467     +118     
- Partials        117      126       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzaeschke tzaeschke force-pushed the fix/30-datagram-socket branch 5 times, most recently from 89c5f96 to f02d15d Compare April 5, 2024 09:17
@tzaeschke tzaeschke force-pushed the fix/30-datagram-socket branch 4 times, most recently from e255e37 to 6894173 Compare April 17, 2024 14:43
@tzaeschke tzaeschke force-pushed the fix/30-datagram-socket branch 5 times, most recently from 701e43b to b5dc1e9 Compare April 29, 2024 10:17
@tzaeschke tzaeschke merged commit 6949dd2 into master Apr 29, 2024
8 checks passed
@tzaeschke tzaeschke deleted the fix/30-datagram-socket branch April 29, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant