Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatcher port range support #130

Merged
merged 8 commits into from
Nov 12, 2024
Merged

Conversation

tzaeschke
Copy link
Collaborator

Respect the dispatched_ports setting in the topofile / daemon.

See: https://docs.scion.org/en/latest/dev/design/router-port-dispatch.html

@tzaeschke tzaeschke self-assigned this Oct 14, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 78.31325% with 18 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/main/java/org/scion/jpan/ScionService.java 64.28% 4 Missing and 1 partial ⚠️
...in/java/org/scion/jpan/internal/LocalTopology.java 87.09% 1 Missing and 3 partials ⚠️
...n/java/org/scion/jpan/AbstractDatagramChannel.java 87.50% 1 Missing and 1 partial ⚠️
src/main/java/org/scion/jpan/PathPolicy.java 0.00% 2 Missing ⚠️
.../scion/jpan/internal/SelectingDatagramChannel.java 71.42% 2 Missing ⚠️
src/main/java/org/scion/jpan/ScmpSenderAsync.java 66.66% 0 Missing and 1 partial ⚠️
src/main/java/org/scion/jpan/internal/Shim.java 80.00% 0 Missing and 1 partial ⚠️
...ain/java/org/scion/jpan/socket/DatagramSocket.java 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ Complexity Δ
src/main/java/org/scion/jpan/Constants.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
.../main/java/org/scion/jpan/ScionDatagramSocket.java 55.51% <100.00%> (+0.16%) 59.00 <4.00> (+1.00)
src/main/java/org/scion/jpan/ScmpSenderAsync.java 88.32% <66.66%> (+1.98%) 21.00 <0.00> (+1.00)
src/main/java/org/scion/jpan/internal/Shim.java 75.00% <80.00%> (-6.58%) 18.00 <0.00> (ø)
...ain/java/org/scion/jpan/socket/DatagramSocket.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...n/java/org/scion/jpan/AbstractDatagramChannel.java 83.26% <87.50%> (-1.82%) 78.00 <3.00> (+1.00) ⬇️
src/main/java/org/scion/jpan/PathPolicy.java 24.48% <0.00%> (ø) 1.00 <0.00> (ø)
.../scion/jpan/internal/SelectingDatagramChannel.java 80.00% <71.42%> (-2.93%) 9.00 <0.00> (+2.00) ⬇️
...in/java/org/scion/jpan/internal/LocalTopology.java 83.20% <87.09%> (+5.11%) 26.00 <5.00> (+6.00)
src/main/java/org/scion/jpan/ScionService.java 70.50% <64.28%> (+0.92%) 59.00 <3.00> (+3.00)

... and 4 files with indirect coverage changes

@tzaeschke tzaeschke mentioned this pull request Oct 16, 2024
@tzaeschke tzaeschke closed this Oct 21, 2024
@tzaeschke tzaeschke force-pushed the fix/130-dispatcher-port-range branch from c5c7ce7 to 2b04f1d Compare October 21, 2024 11:03
@tzaeschke tzaeschke reopened this Oct 21, 2024
@tzaeschke tzaeschke force-pushed the fix/130-dispatcher-port-range branch from a5d534e to 1d3698d Compare October 25, 2024 14:18
@tzaeschke tzaeschke force-pushed the fix/130-dispatcher-port-range branch from cb1776c to 0e26a82 Compare November 6, 2024 16:40
@tzaeschke tzaeschke force-pushed the fix/130-dispatcher-port-range branch from 63a2f31 to db55502 Compare November 11, 2024 16:09
@tzaeschke tzaeschke merged commit 0ecb59c into master Nov 12, 2024
9 checks passed
@tzaeschke tzaeschke deleted the fix/130-dispatcher-port-range branch November 12, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant