Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discovery server port 8041 default #128

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Discovery server port 8041 default #128

merged 1 commit into from
Oct 11, 2024

Conversation

tzaeschke
Copy link
Collaborator

@tzaeschke tzaeschke commented Oct 11, 2024 •
edited
Loading

  • Add default port 8041 to any configured discovery server if no port is given
  • Improve error message when connecting to discovery server

@tzaeschke tzaeschke self-assigned this Oct 11, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ Complexity Δ
...ava/org/scion/jpan/internal/ScionBootstrapper.java 81.25% <100.00%> (ø) 17.00 <0.00> (ø)

@tzaeschke tzaeschke merged commit acaf310 into master Oct 11, 2024
9 checks passed
@tzaeschke tzaeschke deleted the fix/128-discovery-error-message branch October 11, 2024 11:32
@tzaeschke tzaeschke changed the title Doscovery server port 8041 default Discovery server port 8041 default Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tzaeschke tzaeschke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tzaeschke