Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable DNS search domain #118

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Configurable DNS search domain #118

merged 3 commits into from
Sep 16, 2024

Conversation

tzaeschke
Copy link
Collaborator

Add environment variable / property to specify DNS search domain

@tzaeschke tzaeschke self-assigned this Sep 16, 2024
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 52.38095% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...c/main/java/org/scion/jpan/internal/DNSHelper.java 56.25% 5 Missing and 2 partials ⚠️
...in/java/org/scion/jpan/internal/PathRawParser.java 0.00% 3 Missing ⚠️
Files with missing lines Coverage Δ Complexity Δ
src/main/java/org/scion/jpan/Constants.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
src/main/java/org/scion/jpan/ScionService.java 66.54% <100.00%> (+0.24%) 51.00 <0.00> (ø)
...in/java/org/scion/jpan/internal/PathRawParser.java 65.85% <0.00%> (ø) 13.00 <0.00> (ø)
...c/main/java/org/scion/jpan/internal/DNSHelper.java 71.25% <56.25%> (-2.67%) 21.00 <14.00> (+1.00) ⬇️

@tzaeschke tzaeschke merged commit af0d1f4 into master Sep 16, 2024
8 of 9 checks passed
@tzaeschke tzaeschke deleted the fix/119-dns-search-domain branch September 16, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant