Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve path deduplication #117

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Improve path deduplication #117

merged 3 commits into from
Aug 19, 2024

Conversation

tzaeschke
Copy link
Collaborator

Currently, the path resolver may returns multiple paths (only for shortcuts) that differ only in segment ID/MAC/expiration date but have identical IF IDs.
Instead we should retiurn one the one that ensures the maximum validity.

Tilmann Zäschke added 2 commits August 16, 2024 18:24
@tzaeschke tzaeschke self-assigned this Aug 16, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 87.69231% with 8 lines in your changes missing coverage. Please review.

Files Patch % Lines
...org/scion/jpan/internal/PathDuplicationFilter.java 80.95% 5 Missing and 3 partials ⚠️
Files Coverage Δ Complexity Δ
...va/org/scion/jpan/internal/PathRawParserLight.java 100.00% <100.00%> (ø) 8.00 <8.00> (?)
...rc/main/java/org/scion/jpan/internal/Segments.java 85.58% <100.00%> (+1.10%) 96.00 <0.00> (-3.00) ⬆️
...org/scion/jpan/internal/PathDuplicationFilter.java 80.95% <80.95%> (ø) 9.00 <9.00> (?)

@tzaeschke tzaeschke merged commit 7e994c9 into master Aug 19, 2024
9 checks passed
@tzaeschke tzaeschke deleted the fix/116-path-deduplication branch August 19, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant