-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Windows compatibility. #82
Conversation
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
=======================================
Coverage 92.41% 92.41%
=======================================
Files 3 3
Lines 145 145
Branches 24 24
=======================================
Hits 134 134
Misses 9 9
Partials 2 2 Continue to review full report at Codecov.
|
This reverts commit be9d2cf.
Looks good to me. |
This is so great, thank you so much @bdice and @lmcinnes. If this works, it will save me tons of time re-implementing a numba version of ripser. I am noticing this problem in the CI however:
I'm surprised by this; why wouldn't this be imported in the std library? Is there a similar function that does the same thing? |
@ctralie Ah! I didn't see this on my local Windows build for some reason -- might be a difference in Visual Studio versions? As suggested in erengy/anitomy#2, I added |
With help from @lmcinnes, I specialized the
ripser
class in C++ to fix build problems with Windows.This PR uses MSVC instead of MINGW on Appveyor, enhancing compatibility with mainstream Windows. This should also make it possible to enable Windows builds via conda-forge.