Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataFrameMapper using FeatureUnion #64

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

dukebody
Copy link
Collaborator

This PR tries to solve #61 and builds on #62 with the following important additions:

  • get_params and set_params methods to be able to modify estimator parameters during grid-search and others.
  • improved naming for steps, using sklearn's _name_estimators.
  • Allow to specify custom feature names in the third element of the feature definition tuple to avoid (I believe unfrequent) name collisions.

Perhaps we are missing some extra documentation in README.rst?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant