bug fixed: Unexpected Dropping of columns #263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was indicated in the Unexpected Dropping of columns issue where the user there was no effect of passing the
drop_cols
argument in theDataFrameMapper
and the output columns were also wrong.I have modified the
_build(self, X=None):
function insideDataFrameMapper
class and added code to filter the columns based onself.drop_cols
variable.Previous build function:
The modified function:
This will filter the columns based on the
self.drop_cols
variable and will get the filtered columns. I am a beginner in open source contribution and this is my first pull request. Please feel free to give me any suggestions.