Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump supported and testes Python versions #228

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

PicoCentauri
Copy link
Collaborator

@PicoCentauri PicoCentauri commented May 3, 2024

Following sklearn the new supported Python versions are ranging from 3.9 - 3.12. I also simplified the syntax in test matrix a bit.


📚 Documentation preview 📚: https://scikit-matter--228.org.readthedocs.build/en/228/

@agoscinski
Copy link
Collaborator

Looks good. Can be merged like this!

Maybe one can fix in another PR (next time we touch tox.ini) the version for the lint, build and docs environment to avoid mismatching github workflow and local versions that produce for example different linting errors. As far as I understand the tox docs it is just

basepython = py312

If you agree the suggestion I can make an issue for this

@PicoCentauri
Copy link
Collaborator Author

Looks good. Can be merged like this!

Maybe one can fix in another PR (next time we touch tox.ini) the version for the lint, build and docs environment to avoid mismatching github workflow and local versions that produce for example different linting errors. As far as I understand the tox docs it is just

basepython = py312

If you agree the suggestion I can make an issue for this

Could be an option. But if developers (including me 🤣) want to build the docs with an older interpreter they can't anymore if we change this. Older versions compared to 3.12 should in principle work.

@PicoCentauri PicoCentauri merged commit bd54517 into main May 3, 2024
11 checks passed
@PicoCentauri PicoCentauri deleted the bump-python branch May 3, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants