fix plotting fast_hdbscan condensed trees #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests should pass once |
JelmerBot
force-pushed
the
dev/fix-plot
branch
from
b578274 to
eda6caf
Compare
|
I think if you resync from master it should pick up the |
JelmerBot
force-pushed
the
dev/fix-plot
branch
from
eda6caf to
0b4000a
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent change to a floating point
child_sizein fast_hdbscan'scondensed_treebroke its interoperability with theCondensedTree._select_clusters()plotting functionality. This PR resolves the issue by detecting selected clusters through cluster labels, rather than re-computing them from the condensed tree. The main advantage of this approach is that it works without knowing all the ways clusters can be extracted from the condensed tree implemented in both repositories.Only the code in
flat.pyused the_select_clusters()function. That file already contains a (re-)implementation of the required functionality (_new_select_clusters()) . So, I changed it to use that function instead.