Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better elif conditions for obj __init__ methods #316

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

Saransh-cpp
Copy link
Member

Description

The elif condition missed checking for the longitudinal and temporal arguments.

Checklist

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't any other open Pull Requests for the required change?
  • Does your submission pass pre-commit? ($ pre-commit run --all-files or $ nox -s lint)
  • Does your submission pass tests? ($ pytest or $ nox -s tests)
  • Does the documentation build with your changes? ($ cd docs; make clean; make html or $ nox -s docs)
  • Does your submission pass the doctests? ($ xdoctest ./src/vector or $ nox -s doctests)

Before Merging

  • Summarize the commit messages into a brief review of the Pull request.

@Saransh-cpp Saransh-cpp added the bug The problem described is something that must be fixed label Feb 17, 2023
@Saransh-cpp Saransh-cpp added this to the v1.0.0 milestone Feb 17, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 82.67% // Head: 82.67% // No change to project coverage 👍

Coverage data is based on head (d1e25bd) compared to base (9310cd4).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #316   +/-   ##
=======================================
  Coverage   82.67%   82.67%           
=======================================
  Files          96       96           
  Lines       11424    11424           
=======================================
  Hits         9445     9445           
  Misses       1979     1979           
Impacted Files Coverage Δ
src/vector/backends/object.py 74.85% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Saransh-cpp Saransh-cpp merged commit 9b46599 into scikit-hep:main Feb 17, 2023
@Saransh-cpp Saransh-cpp deleted the if-else-miss branch February 17, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The problem described is something that must be fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants