chore: move to using Ruff #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
henryiii
commented
Feb 17, 2023
henryiii
commented
- chore: move to using Ruff
- style: make Ruff happy
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/chore/ruff
branch
from
289a7d6 to
3a09183
Compare
henryiii
commented
Feb 17, 2023
Comment on lines
736
to
742
| len(returns) == 2 | ||
| and isinstance(returns[0], type) | ||
| and issubclass(returns[0], Azimuthal) | ||
| and returns[1] is None | ||
| ): | ||
| azcoords = _coord_object_type[returns[0]](result[0], result[1]) | ||
| return cls.ProjectionClass2D(azimuthal=azcoords) | ||
|
|
||
| elif ( | ||
| len(returns) == 2 | ||
| and isinstance(returns[0], type) | ||
| and issubclass(returns[0], Azimuthal) | ||
| and isinstance(returns[1], type) | ||
| and issubclass(returns[1], Longitudinal) | ||
| ): | ||
| azcoords = _coord_object_type[returns[0]](result[0], result[1]) | ||
| lcoords = _coord_object_type[returns[1]](result[2]) | ||
| return cls.ProjectionClass3D(azimuthal=azcoords, longitudinal=lcoords) | ||
|
|
||
| elif ( | ||
| len(returns) == 3 | ||
| or (len(returns) == 3 and returns[2] is None) | ||
| and isinstance(returns[0], type) | ||
| and issubclass(returns[0], Azimuthal) | ||
| and isinstance(returns[1], type) | ||
| and issubclass(returns[1], Longitudinal) | ||
| and returns[2] is None | ||
| ): |
There was a problem hiding this comment.
I had to manually make these changes, but pretty impressed Ruff noticed it could be made. :)
henryiii
commented
Feb 17, 2023
| - id: flake8 | ||
| additional_dependencies: | ||
| - flake8-bugbear | ||
| - flake8-docstrings |
There was a problem hiding this comment.
For some reason, Ruff's "D" code catches a lot of stuff the old one didn't. So I've removed it for now, and we can enable new codes (including "D") in the future.
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/chore/ruff
branch
from
3a09183 to
44f5cf2
Compare
henryiii
commented
Feb 17, 2023
| @@ -694,7 +694,7 @@ def momentum_rhophizt(): | |||
| assert out.pt == pytest.approx(2) | |||
| assert out.phi == pytest.approx(3.3) | |||
| assert out.z == pytest.approx(5) | |||
| assert out.E == pytest.approx(10) | |||
| assert out.E == pytest.approx(10) # noqa: SIM300 | |||
There was a problem hiding this comment.
Yoda conditions thinks ".E" is a constant.
henryiii
commented
Feb 17, 2023
|
|
||
| @numba.njit | ||
| def get_false(v): | ||
| return False if v else True | ||
| return False if v else True # noqa: SIM211 |
There was a problem hiding this comment.
We don't support not v, which is a little strange, but just noqa'd it. not bool(v) probably would have worked, since I think bool(v) above worked. But that also might have been simplified by a SIM code.
|
Ruff looks amazing! 🤩 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.