Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update pre-commit hooks #306

Merged
merged 2 commits into from
Jan 16, 2023
Merged

chore: update pre-commit hooks #306

merged 2 commits into from
Jan 16, 2023

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Jan 9, 2023

@pre-commit-ci
chore: update pre-commit hooks
c1b85e6 
updates:
- [github.com/nbQA-dev/nbQA: 1.6.0 → 1.6.1](nbQA-dev/nbQA@1.6.0...1.6.1)
@Saransh-cpp
Copy link
Member

pre-commit.ci run

Saransh-cpp
Saransh-cpp approved these changes Jan 15, 2023
View reviewed changes
Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checks do pass locally. Not very sure why the pre-commit CI is failing. Will look for fixes before merging this in.

@Saransh-cpp
Copy link
Member

(The discheck failure is unrelated. Looking into that too.)

@Saransh-cpp Saransh-cpp mentioned this pull request Jan 16, 2023
Closed
@Saransh-cpp Saransh-cpp merged commit b135c88 into main Jan 16, 2023
@Saransh-cpp Saransh-cpp deleted the pre-commit-ci-update-config branch January 16, 2023 18:37
@henryiii
Copy link
Member

This is pinned to numpy==1.22.0. That doesn't have a Python 3.11 wheel. I'd recommend numpy~=1.23.0 or numpy~=1.24.0 instead.

@Saransh-cpp Saransh-cpp mentioned this pull request Jan 18, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saransh-cpp Saransh-cpp Saransh-cpp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Saransh-cpp @henryiii