Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing backslash in latex for readme #285

Merged

Conversation

meliache
Copy link
Contributor

@meliache meliache commented Oct 27, 2022


Description

While checking the available methods in the github readme I noticed that one $Delta$ didn't render properly as $\Delta$ so I decided to quickly fix add the missing backslash. On my fork this renders properly now. For testing I just ran pre-commit to check that I my editor didn't do any weird whitespace changes that I didn't notice. But I didn't run the unit tests or the doctests as I didn't change anything in the code. Should I?

Checklist

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't any other open Pull Request for the required change ?
  • Does your submission pass pre-commit? ($ pre-commit run --all-files or $ nox -s lint)
  • Does your submission pass tests? ($ pytest or $ nox -s tests)
  • Does the documentation build with your changes? ($ cd docs; make clean; make html or $ nox -s docs)
  • Does your submission pass doctests? ($ xdoctest ./src/vector or $ nox -s doctests)

Before Merging

  • Summarize commit messages into a brief review of the Pull request.

@codecov-commenter
Copy link

Codecov Report

Base: 81.08% // Head: 81.08% // No change to project coverage 👍

Coverage data is based on head (f465e86) compared to base (4fbbd81).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #285   +/-   ##
=======================================
  Coverage   81.08%   81.08%           
=======================================
  Files          96       96           
  Lines       10672    10672           
=======================================
  Hits         8653     8653           
  Misses       2019     2019           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @meliache! No need to run the tests locally :)

@Saransh-cpp Saransh-cpp merged commit 30cd3ed into scikit-hep:main Oct 28, 2022
@Saransh-cpp Saransh-cpp added this to the v0.11.0 milestone Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants