Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update changelog.md, PR template, and CONTRIBUTING.md #275

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

Saransh-cpp
Copy link
Member

@Saransh-cpp Saransh-cpp commented Oct 18, 2022

Description

  • The changelog was outdated (we should try updating it with every PR)
  • Minor typo in PR template
  • Add documentation for nox -s notebooks

Checklist

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't any other open Pull Request for the required change ?
  • Does your submission pass pre-commit? ($ pre-commit run --all-files or $ nox -s lint)
  • Does your submission pass tests? ($ pytest or $ nox -s tests)
  • Does the documentation build with your changes? ($ cd docs; make clean; make html or $ nox -s docs)
  • Does your submission pass doctests? ($ xdoctest ./src/ocres or $ nox -s doctests)

Before Merging

  • Summarize commit messages into a brief review of the Pull request.

@Saransh-cpp Saransh-cpp added the docs Improvements or additions to documentation label Oct 18, 2022
@Saransh-cpp Saransh-cpp merged commit 23a10c5 into scikit-hep:main Oct 18, 2022
@Saransh-cpp Saransh-cpp deleted the update-docs branch October 18, 2022 08:28
@Saransh-cpp Saransh-cpp added this to the v1.0.0 milestone Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant