fix: vector.arr should construct NumPy vectors
#254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 81.04% // Head: 81.04% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #254 +/- ##
=======================================
Coverage 81.04% 81.04%
=======================================
Files 96 96
Lines 10623 10624 +1
=======================================
+ Hits 8609 8610 +1
Misses 2014 2014
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Will merge this in today! ("can merge small bug fixes without a review" - a small bug fix from developer's perspective, but might break scripts that are using this bug as a feature) |
Saransh-cpp
force-pushed
the
numpy-constr
branch
from
e52325f to
37a90b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all the examples located in
vector, as well as the introduction to constructors here - https://github.com/scikit-hep/vector#constructing-a-vector-or-an-array-of-vectors - point to the fact thatvector.arrshould constructNumPyvectors. This also seems logical (Array->awk,array->arr), and is most probably not wrong in the examples.