Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add constructors for VectorObject3D and MomentumObject3D #231

Merged
merged 17 commits into from
Feb 17, 2023

Conversation

Saransh-cpp
Copy link
Member

The branches for VectorObject3D and VectorObject4D` were going stale on my fork. I have decided to keep them open as draft PRs and mark them ready for review once #89 is merged. This way, I can periodically check on them and keep them synced with the latest changes.

Note
This pull request is built on top of #89; hence it has the changes of #89 too. I will sync this PR once #89 is merged.

@Saransh-cpp Saransh-cpp marked this pull request as draft July 29, 2022 15:31
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2022

Codecov Report

Base: 81.08% // Head: 81.07% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (057d2bd) compared to base (4fbbd81).
Patch coverage: 73.98% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
- Coverage   81.08%   81.07%   -0.02%     
==========================================
  Files          96       96              
  Lines       10672    10777     +105     
==========================================
+ Hits         8653     8737      +84     
- Misses       2019     2040      +21     
Impacted Files Coverage Δ
src/vector/_methods.py 77.94% <67.10%> (-0.66%) ⬇️
src/vector/backends/object.py 74.41% <85.10%> (+0.73%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Saransh-cpp Saransh-cpp changed the title feat: add constructor for VectorObject3D feat: add constructors for VectorObject3D and MomentumObject3D Jul 29, 2022
@Saransh-cpp Saransh-cpp added the feature New feature or request label Aug 29, 2022
@Saransh-cpp Saransh-cpp added this to the v1.0.0 milestone Aug 29, 2022
@Saransh-cpp Saransh-cpp force-pushed the saransh/3D-object-constructors branch from 75c1e9b to 84182e8 Compare September 22, 2022 18:46
@Saransh-cpp Saransh-cpp force-pushed the saransh/3D-object-constructors branch from 4ccf961 to d8e44b4 Compare October 18, 2022 09:15
@Saransh-cpp Saransh-cpp marked this pull request as ready for review October 18, 2022 09:15
@Saransh-cpp Saransh-cpp requested a review from henryiii October 18, 2022 09:17
@henryiii
Copy link
Member

I missed that this was ready...

@henryiii henryiii merged commit b1bd185 into scikit-hep:main Feb 17, 2023
@Saransh-cpp Saransh-cpp deleted the saransh/3D-object-constructors branch February 17, 2023 07:05
@Saransh-cpp
Copy link
Member Author

Thanks! Updated #232 with the changes, should be ready to review as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants