Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add pyproject-fmt pre-commit hook #230

Merged
merged 2 commits into from
Jul 29, 2022

Conversation

Saransh-cpp
Copy link
Member

Now that vector uses only pyproject.toml for specifying all the build and packaging-related things, I think adding this hook would be a good idea.

@codecov-commenter
Copy link

Codecov Report

Merging #230 (60d9384) into main (cac88a2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #230   +/-   ##
=======================================
  Coverage   82.63%   82.63%           
=======================================
  Files          96       96           
  Lines       10524    10524           
=======================================
  Hits         8697     8697           
  Misses       1827     1827           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cac88a2...60d9384. Read the comment docs.

@Saransh-cpp Saransh-cpp requested a review from henryiii July 27, 2022 09:23
@Saransh-cpp
Copy link
Member Author

I think this should be okay to merge without a review as pyproject-fmt is in the process of being added to Scikit-HEP developer pages - scikit-hep/scikit-hep.github.io#214!

@Saransh-cpp Saransh-cpp merged commit 056f638 into scikit-hep:main Jul 29, 2022
@Saransh-cpp Saransh-cpp deleted the pyproject-fmt branch July 29, 2022 15:02
@Saransh-cpp Saransh-cpp added this to the v0.9.0 milestone Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants