Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to hatchling #223

Merged
merged 8 commits into from
Jul 19, 2022

Conversation

Saransh-cpp
Copy link
Member

  • add .flake8 for flake8 config
  • remove setup-cfg-fmt pre-commit
  • remove setup.*
  • migrate to hatchling

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2022

Codecov Report

Merging #223 (ef9dea9) into main (02d4655) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
+ Coverage   82.56%   82.58%   +0.01%     
==========================================
  Files          96       96              
  Lines       10475    10483       +8     
==========================================
+ Hits         8649     8657       +8     
  Misses       1826     1826              
Impacted Files Coverage Δ
src/vector/_compute/spatial/z.py 100.00% <0.00%> (ø)
src/vector/_compute/planar/unit.py 100.00% <0.00%> (ø)
src/vector/_compute/spatial/eta.py 100.00% <0.00%> (ø)
src/vector/_compute/lorentz/beta.py 100.00% <0.00%> (ø)
src/vector/_compute/lorentz/unit.py 100.00% <0.00%> (ø)
src/vector/_compute/spatial/unit.py 100.00% <0.00%> (ø)
src/vector/_compute/lorentz/gamma.py 100.00% <0.00%> (ø)
src/vector/_compute/spatial/costheta.py 100.00% <0.00%> (ø)
src/vector/_compute/spatial/cottheta.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02d4655...ef9dea9. Read the comment docs.

@Saransh-cpp
Copy link
Member Author

Thank you for the review, @henryiii! Weirdly, the disassemble check fails due to no test_extras dependencies being installed -

WARNING: vector 0.1.dev1+g5255483 does not provide the extra 'test_extras'

@Saransh-cpp Saransh-cpp force-pushed the saransh/hatchling-backend branch from dd568ea to 17ef854 Compare July 5, 2022 20:27
@Saransh-cpp
Copy link
Member Author

Saransh-cpp commented Jul 5, 2022

Turns out, pyproject.toml has a problem with extras having _ in their name.

@Saransh-cpp Saransh-cpp requested a review from henryiii July 5, 2022 20:54
@Saransh-cpp
Copy link
Member Author

Works with -! Thanks, @henryiii!

@Saransh-cpp
Copy link
Member Author

Should I go ahead and merge this?

@Saransh-cpp Saransh-cpp merged commit cac88a2 into scikit-hep:main Jul 19, 2022
@Saransh-cpp Saransh-cpp deleted the saransh/hatchling-backend branch July 19, 2022 14:20
@Saransh-cpp Saransh-cpp added this to the v0.9.0 milestone Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants