Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom reprs to awkward coordinate classes #212

Merged
merged 4 commits into from
Jun 27, 2022

Conversation

Saransh-cpp
Copy link
Member

@Saransh-cpp Saransh-cpp commented Jun 25, 2022

Closes #209

  • Add custom __repr__ methods
  • Update the doctests to reflect the same

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2022

Codecov Report

Merging #212 (63976f5) into main (ba4e8b4) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
- Coverage   82.45%   82.43%   -0.02%     
==========================================
  Files          96       96              
  Lines       10388    10394       +6     
==========================================
+ Hits         8565     8568       +3     
- Misses       1823     1826       +3     
Impacted Files Coverage Δ
src/vector/backends/awkward.py 75.89% <50.00%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba4e8b4...63976f5. Read the comment docs.

@Saransh-cpp Saransh-cpp requested a review from henryiii June 25, 2022 16:59
Copy link
Member

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switch to f-strings, slightly faster and cleaner, otherwise good!

Saransh-cpp and others added 2 commits June 28, 2022 00:33
Co-authored-by: Henry Schreiner <HenrySchreinerIII@gmail.com>
@Saransh-cpp Saransh-cpp merged commit b2c60b5 into scikit-hep:main Jun 27, 2022
@Saransh-cpp Saransh-cpp deleted the saransh/reprs branch June 27, 2022 19:19
@Saransh-cpp Saransh-cpp added this to the v0.9.0 milestone Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the __repr__ methods of Awkward classes
3 participants