Implement doctests in CI #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
reviewed
Jun 24, 2022
| >>> a = vector.Array( | ||
| ... [{"px": 1, "py": 1.1, "z": 0.1, "m": 1}, {"px": 2, "py": 2.2, "z": 0.2, "m": 3}], | ||
| ... ) | ||
| >>> a.longitudinal | ||
| <vector.backends.awkward.LongitudinalAwkwardZ object at 0x0000028231215A80> |
There was a problem hiding this comment.
I thought xdoctest recognized the pointers here in an object default repr and still compared correctly? (not sure it's important to show, but just thinking it should have worked if that's the problem)
There was a problem hiding this comment.
Yes, locally xdoctest fails the doctests on these outputs. I will get them up in the PR closing #209!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #208
xdocteststotestdependepncies