-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add docstrings in the backends.object
module
#201
docs: add docstrings in the backends.object
module
#201
Conversation
Codecov Report
@@ Coverage Diff @@
## main #201 +/- ##
=======================================
Coverage 82.44% 82.45%
=======================================
Files 96 96
Lines 10387 10388 +1
=======================================
+ Hits 8564 8565 +1
Misses 1823 1823
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend not waiting for a review for more docs. It's always nice to have a second set of eyes, but adding missing docs is not ideal for easy reviewing, so I'd recommend just moving ahead unless you have specific questions.
To clear up something Jim wanted to make sure was clear - you don't "need" a review to merge things here. It's just nice to have a second set of eyes on things; I like to have a review if I can even on my own repos.
That's right—I'll be a second reviewer depending on severity. Of course I like to stay aware of changes and provide feedback, but my backlog is pretty long. You don't need to wait for a review from me to decide to merge. |
Got it! Thank you for the clarification! |
Added docstrings and minor examples!