-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove underscores #192
Remove underscores #192
Conversation
Is there a file where I should add a warning for this? The issue mentions that the |
The issue says that interfaces in the backends package could be used by third-party developers in the future, and However, it would be worthwhile checking inside |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the modules in backends
that I could see make good use of leading underscores for private implementations, except for the numba
and numba_object
backends. So just make these
backends/numba
→backends/_numba
backends/numba_objects
→backends/_numba_objects
and that should be it. 100% of the Numba code is registering things in Numba itself: the variables and functions that are left around after doing that are of no interest to third-party developers and should be hidden so that we're free to change them.
Thank you for the review! Yes, the |
`awkward_` -> `awkward`
`_backend` -> `backend`
Missed some underscores in documentation
`numba` -> `_numba` and `numba_object` -> `_numba_object`
4b93108
to
52d333c
Compare
Closes #136
Underscores removed
object_
->object
awkward_
->awkward
numpy_
->numpy
numba_
->numba
_backends
->backends