Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Conda and Zenodo badges to the README #183

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Conversation

eduardo-rodrigues
Copy link
Member

I also rearranged a bit to follow the looks of the badges as in other packages.

README.md Outdated
# Vector
# Vector: arrays of 2D, 3D, and Lorentz vectors

[![Scikit-HEP][sk-badge]][sk-link]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Scikit-HEP badge is always last, I believe. At least it's always in the last group. Actually, if the order of these two grapes was swapped, I think it would be pretty close. The idea was to have the standard "status" badges in the first row (like tests and such), and informational badges (like versions and DOI's) in the second row.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reordered them a little bit.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I like, but it does not matter anyway. I prefer the way it is in Particle and DecayLanguage, which is what I followed.

Approved from you, then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I like the "status" badges on the top, since that's what the badges originally were for, and that's what users are used to seeing them used as. We've sort of "hijacked" them over time to show static links, but they were originally live statuses for CI. The lower/second line can be the "informational" one - expecially the scikit-hep badge, which is just a completely static link. Placing it completely last does give it a special spot, though.

Eventually we should add some recommendations and maybe even checking for the badges and their order...

@henryiii henryiii merged commit ce0baad into main Apr 7, 2022
@henryiii henryiii deleted the eduardo-add-zenodo-badge branch April 7, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants