Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support Content objects in writing #986

Merged
merged 1 commit into from
Oct 12, 2023
Merged

fix: support Content objects in writing #986

merged 1 commit into from
Oct 12, 2023

Conversation

agoose77
Copy link
Collaborator

No description provided.

@agoose77 agoose77 force-pushed the agoose77/fix-final-asarray-510 branch from cc49ef6 to 85edc0f Compare October 12, 2023 17:48
@agoose77 agoose77 changed the base branch from main to main-v510 October 12, 2023 17:48
@agoose77 agoose77 requested a review from jpivarski October 12, 2023 17:48
@jpivarski
Copy link
Member

This is a forward-port of #985, right? It's missing content → content.data in

uproot5/src/uproot/writing/_cascadetree.py

Line 785 in 4a977f6

big_endian = numpy.asarray(content.data, dtype=datum["dtype"])

@agoose77
Copy link
Collaborator Author

agoose77 commented Oct 12, 2023 •
edited
Loading

Yes, but that change is already in this branch :)

@jpivarski
Copy link
Member

Indeed it is!

@jpivarski jpivarski merged commit f999bd9 into main-v510 Oct 12, 2023
@jpivarski jpivarski deleted the agoose77/fix-final-asarray-510 branch October 12, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agoose77 @jpivarski