-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for reading free floating std::vector #1180
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I went back and forth on the priority order; now it's
- check for any globally- or per-file-defined Models
- load the file's streamers and look for any Models the streamers might have defined
- check for explicit STL classes, like
std::vector<T>
(where theT
might have been defined by one of the streamers, so we had to check - give up and call it UnknownClass.
The regex is now
(std\s*::\s*)?(vector|map|set|string|bitset)
because we want exactly one of the STL class names to match.
But it looks good, the test does the right thing, and it's ready to merge.
Another alteration: this is similar to #1160, but that implementation checked for However, I could make the code that handled the #1160 case more symmetric. It can check for both Now it's ready to merge. |
No description provided.