Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the ability to read RNTuple alias columns #1004

Merged
merged 14 commits into from
Jan 18, 2024

Conversation

ioanaif
Copy link
Collaborator

@ioanaif ioanaif commented Oct 20, 2023

Fixes #928 and #975

@ioanaif ioanaif linked an issue Oct 20, 2023 that may be closed by this pull request
@jpivarski
Copy link
Member

The new docs/readthedocs.org:uproot test requirement can be satisfied by merging #1084/jpivarski/fix-readthedocs-documentation into this PR (or by merging in main, which has it).

@ioanaif ioanaif marked this pull request as ready for review January 18, 2024 15:43
@ioanaif ioanaif requested a review from jpivarski January 18, 2024 15:43
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a big step forward for handling alias columns. I saw it in many stages of development, and the final diff is small but a definite improvement. The new tests have to be marked xfail, but that will be a good starting point for @ariostas.

@jpivarski jpivarski changed the title fix: new rntuple events reading feat: add the ability to read RNTuple alias columns Jan 18, 2024
@jpivarski jpivarski enabled auto-merge (squash) January 18, 2024 15:49
@jpivarski jpivarski merged commit 0913f36 into main Jan 18, 2024
20 checks passed
@jpivarski jpivarski deleted the ioanaif/rntuple-support-events branch January 18, 2024 16:15
lobis added a commit that referenced this pull request Jan 22, 2024
* origin/main: (41 commits)
  chore: hatch-vcs generates 'version.py'; add it to .gitignore
  docs: add bnavigator as a contributor for test (#1087)
  feat: support for writing hist derived profiles (#1000)
  feat: add the ability to read RNTuple alias columns (#1004)
  chore: update pre-commit hooks (#1082)
  docs: fix ReadTheDocs documentation (#1084)
  chore: update pre-commit hooks (#1073)
  chore(deps): bump actions/upload-artifact from 3 to 4 (#1071)
  chore(deps): bump actions/download-artifact from 3 to 4 (#1072)
  build: change build to autogen version info (#1062)
  chore: remove src/uproot/version.py (for #1062).
  The next release will be 5.2.1.
  add known_base_form option so that opening root files can be avoided for mature analyses (#1077)
  test: fsspec cache (#1075)
  test: xrootd server fixture (#1076)
  The next release will be 5.2.0.
  fix: correct typo in fsspec globbing (#1067)
  chore(deps): bump actions/setup-python from 4 to 5 (#1059)
  The next release will be 5.2.0rc5.
  fix: dask distributed fsspec issue (#1065)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reading the RNtuple PHYSLITE prototype Add support for current RNTuple files
3 participants